[wp-trac] [WordPress Trac] #39665: Customize: nav menu fallbacks don't get edit shortcuts

[WordPress Trac]

#39665: Customize: nav menu fallbacks don't get edit shortcuts
-------------------------------------+------------------
 Reporter:  celloexpressions         |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  4.8
Component:  Customize                |     Version:  4.7
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+------------------

Comment (by dlh):

 I tested [attachment:39665.3.diff] and found it generally works as
 expected. I came up with a few comments and questions:

 - If the `fallback_cb` doesn't output HTML, then the additional attributes
 in `filter_wp_nav_menu()` aren't added to the output.

 - As a UX matter, do you think it makes sense to a user for the edit link
 to take them somewhere where they weren't editing the thing in the
 preview? The user would have to understand that they're "editing" the fact
 that there isn't a menu assigned to the location, as opposed to being able
 to edit the list of links output by `wp_page_menu()` or editing whatever
 the `fallback_cb` was. While the current nav menu edit links go to the
 same place as the new ones would, there's at least an "Edit Menu" link.

 - Presumably it's rare, but if someone already happened to provide support
 for edit links in their `fallback_cb`, then I think there would be two
 edit links.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39665#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform