[wp-trac] [WordPress Trac] #40808: Media Widgets: VideoPress Uploads Not Functioning Correctly
WordPress Trac
noreply at wordpress.org
Thu May 18 20:26:36 UTC 2017
#40808: Media Widgets: VideoPress Uploads Not Functioning Correctly
----------------------------+-----------------------------------------
Reporter: timmydcrawford | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.8
Component: Widgets | Version:
Severity: normal | Resolution:
Keywords: needs-patch | Focuses: javascript, administration
----------------------------+-----------------------------------------
Changes (by westonruter):
* keywords: => needs-patch
* milestone: Awaiting Review => 4.8
Comment:
I think perhaps a more underlying issue is adding support for more oEmbeds
than just YouTube and Vimeo, as VideoPress is also an oEmbed. So if at the
point of media selection we can then make sure that the widget instance
has a `url` that is the oEmbed URL as opposed to the faux file URL, then
we can enter into the `is_hosted_video` condition. If the URL provided
doesn't look like a file URL, then we could at that point we could assume
that the URL is for an oEmbed fire off an oEmbed proxy request to obtain
the HTML for rendering the player and write it into an iframe.
Another piece to consider is the error message when providing a embed URL.
Let's say you try to add a video by supplying the oEmbed URL itself:
https://videopress.com/v/OAVHZIvv This then should not be rejected. In
order to do that we should be exporting all of the
`\WP_oEmbed::$providers` to the client so that we can check against them
instead of statically only looking for YouTube or Vimeo as we do with
hard-coding right now.
See https://github.com/xwp/wp-core-media-
widgets/issues/160#issuecomment-301678111
--
Ticket URL: <https://core.trac.wordpress.org/ticket/40808#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list