[wp-trac] [WordPress Trac] #40735: Events widget form should close after successful search

WordPress Trac noreply at wordpress.org
Thu May 18 09:46:12 UTC 2017


#40735: Events widget form should close after successful search
----------------------------+--------------------------------
 Reporter:  iandunn         |       Owner:
     Type:  enhancement     |      Status:  new
 Priority:  normal          |   Milestone:  Awaiting Review
Component:  Administration  |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:  ui, accessibility
----------------------------+--------------------------------

Comment (by afercia):

 > there are several aria-hidden="false", not sure why they're used

 Replying to myself :) OK I understand now, and using `aria-hidden` also as
 CSS target to toggle visibility is a good pattern! Just wondering if the
 universal selector `*` could be avoided, see below:

 {{{
 .community-events-errors[aria-hidden="true"],
 .community-events-errors *[aria-hidden="true"],
 .community-events-loading[aria-hidden="true"],
 .community-events[aria-hidden="true"],
 .community-events *[aria-hidden="true"] {
         display: none;
 }
 }}}

 Since CSS is read and used by browsers right-to-left that translates in a
 somewhat expensive operation.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40735#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list