[wp-trac] [WordPress Trac] #40783: More accurate media widgets instance schema
WordPress Trac
noreply at wordpress.org
Wed May 17 15:48:54 UTC 2017
#40783: More accurate media widgets instance schema
--------------------------+------------------------------
Reporter: obenland | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Widgets | Version: trunk
Severity: normal | Resolution:
Keywords: close | Focuses:
--------------------------+------------------------------
Changes (by westonruter):
* keywords: => close
Comment:
@obenland I think it makes sense to include these in the base widget's
schema in the PHP class because these same properties are also
[https://github.com/WordPress/wordpress-
develop/blob/2dd4bc7388950661ef1b71e8474b0e5c937bc15a/src/wp-
admin/js/widgets/media-widgets.js#L622 being used] in the base JS class.
If a subclass is not using these, then I think it would be up to them to
remove the `url` and `attachment_id` fields in the schema while also
overriding the relevant JS methods.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/40783#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list