[wp-trac] [WordPress Trac] #39665: Customize: nav menu fallbacks don't get edit shortcuts

WordPress Trac noreply at wordpress.org
Wed May 17 06:22:42 UTC 2017


#39665: Customize: nav menu fallbacks don't get edit shortcuts
-------------------------------------+------------------
 Reporter:  celloexpressions         |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  4.8
Component:  Customize                |     Version:  4.7
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+------------------

Comment (by westonruter):

 @dlh I don't know, I think the solution you came up is pretty awesome. I
 don't assume that `fallback_cb` is specified that frequently, but I could
 be very wrong.

 In any case, I think I have a general solution to this in
 [attachment:39665.3.diff]. By wrapping the `fallback_cb` in another
 function call, we can then call the logic that injects the selective
 refresh HTML attributes regardless of whether there is a filter we can
 hook into. The caveat being that it is currently using a closure which
 would have to be refactored for PHP 5.2 compat.

 Anything I'm missing in this approach?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39665#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list