[wp-trac] [WordPress Trac] #40771: Unable to add YouTube video to Video Widget
WordPress Trac
noreply at wordpress.org
Tue May 16 19:07:11 UTC 2017
#40771: Unable to add YouTube video to Video Widget
--------------------------+--------------------------
Reporter: taijacg | Owner: westonruter
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 4.8
Component: Widgets | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
--------------------------+--------------------------
Comment (by timmydcrawford):
> @timmydcrawford only question I have about [attachment:40771.2.diff] now
is whether or not we really need all of the instances of `trim`. Is
trimming of already-trimmed strings happening?
I believe we still need one in {{{fetch}}} since that is operating
directly from the user input, not the model attribute that has been
sanitized. I agree that the {{{trim}}}s in media-video-widget.js could
likely be removed. I will test and rev the diff if that is the case.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/40771#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list