[wp-trac] [WordPress Trac] #39671: Customize: Further improve inline documentation
WordPress Trac
noreply at wordpress.org
Tue May 16 05:58:09 UTC 2017
#39671: Customize: Further improve inline documentation
--------------------------------------+-------------------
Reporter: westonruter | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.8
Component: Customize | Version:
Severity: normal | Resolution:
Keywords: good-first-bug has-patch | Focuses: docs
--------------------------------------+-------------------
Comment (by westonruter):
There are changes to `kses.php` which seem to have snuck into the patch.
Those need to be removed.
Looking through some of the `@since` tags, I can see that they're not all
accurate. For example `\WP_Customize_Control::$input_attrs` was added in
4.0.0 not 3.4.0 (see #28477). Likewise,
`\WP_Customize_Setting::$validate_callback` was added in 4.6.0 not 3.4.0
(see #34893). So some more QA is needed on the patch.
The changes to the phpdoc comments before each `require_once` in `class-
wp-customize-control.php` shouldn't be necessary. In fact, I don't think
phpdoc comments are even appropriate here.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/39671#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list