[wp-trac] [WordPress Trac] #40755: Textarea in HTML text widget has 1px border
WordPress Trac
noreply at wordpress.org
Sat May 13 16:02:13 UTC 2017
#40755: Textarea in HTML text widget has 1px border
-------------------------------------------------+-------------------------
Reporter: johnjamesjacoby | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting
Component: Widgets | Review
Severity: normal | Version: trunk
Keywords: has-patch 2nd-opinion has- | Resolution:
screenshots | Focuses:
| administration
-------------------------------------------------+-------------------------
Changes (by johnjamesjacoby):
* keywords: => has-patch 2nd-opinion has-screenshots
* focuses: => administration
Comment:
[https://core.trac.wordpress.org/attachment/ticket/40755/40755.patch
40755.patch] addresses the following:
* Removes 1px border
* Sets the line-height to 0 for the `wp-editor-container` to remove the
gap between the bottom of the textarea and the bottom of the container
* Removes the shadow applied to all textarea elements when in focus
A few things I'm not 100% sure about:
* Is `widgets.css` the correct file for this (vs. maybe `forms.css`?)
* Is this the best way to target this textarea (can this class be
overridden in a plugin, is there something faster, or does something
already exist that we can use?)
* Doing `line-height: 0;` on things always feels like a kludge for a
bigger line-height issue, but I'm not going down that rabbit hole here :)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/40755#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list