[wp-trac] [WordPress Trac] #40220: Customizer: Consider natural-width media buttons

WordPress Trac noreply at wordpress.org
Fri May 12 16:18:36 UTC 2017


#40220: Customizer: Consider natural-width media buttons
--------------------------------------------------------+------------------
 Reporter:  melchoyce                                   |       Owner:
     Type:  enhancement                                 |      Status:  new
 Priority:  normal                                      |   Milestone:  4.8
Component:  Customize                                   |     Version:
 Severity:  normal                                      |  Resolution:
 Keywords:  good-first-bug has-screenshots needs-patch  |     Focuses:  ui
--------------------------------------------------------+------------------
Changes (by westonruter):

 * keywords:  good-first-bug has-patch has-screenshots => good-first-bug
     has-screenshots needs-patch


Comment:

 @afercia I just realized the same thing needs to be done for media widgets
 as well. I see now why there was the `margin-top` on the buttons which was
 removed in https://github.com/xwp/wp-core-media-
 widgets/pull/155/commits/8ac4e8dac89a5854f66764ed6add350c0abc66e1

 This was done initially because an [https://github.com/xwp/wp-core-media-
 widgets/issues/148 issue] where the margin between the placeholder and the
 buttons was not consistent with the space between the placeholder and the
 title field above, stemming from the difference between the margin for the
 buttons and the margin for `p` elements.

 Can you apply your fix there as well?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40220#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list