[wp-trac] [WordPress Trac] #40724: Strict get_blog_count() unit test fails on some setups

WordPress Trac noreply at wordpress.org
Thu May 11 08:11:45 UTC 2017


#40724: Strict get_blog_count() unit test fails on some setups
--------------------------------+------------------------
 Reporter:  flixos90            |       Owner:  flixos90
     Type:  defect (bug)        |      Status:  reopened
 Priority:  normal              |   Milestone:  4.8
Component:  Networks and Sites  |     Version:
 Severity:  normal              |  Resolution:
 Keywords:  has-patch           |     Focuses:  multisite
--------------------------------+------------------------

Comment (by flixos90):

 Replying to [comment:3 jorbin]:
 > It seems to me like it may make more sense to keep the `assertSame` and
 do the cast to int. The function is documented to return an integer, the
 expectation should be that it does.

 +1

 I thought this wasn't something to consider because of BC, but if it's
 not, let's go for it!

 I'd prefer to open separate tickets though, one for `get_blog_count()` and
 one for `get_user_count()`, which is also affected.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40724#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list