[wp-trac] [WordPress Trac] #40724: Strict get_blog_count() unit test fails on some setups
WordPress Trac
noreply at wordpress.org
Wed May 10 23:02:44 UTC 2017
#40724: Strict get_blog_count() unit test fails on some setups
--------------------------------+------------------------
Reporter: flixos90 | Owner: flixos90
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 4.8
Component: Networks and Sites | Version:
Severity: normal | Resolution: fixed
Keywords: has-patch | Focuses: multisite
--------------------------------+------------------------
Changes (by flixos90):
* owner: => flixos90
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"40610"]:
{{{
#!CommitTicketReference repository="" revision="40610"
Multisite: Fix unstable unit test for `get_blog_count()`.
The unit test introduced in [40370] used the strict `assertSame()` check
while comparison a count with the value of an option, which under most
conditions is not an integer. While the test passed on some setups, it
failed on others. This changeset ensures that `assertEquals()` is used to
make the test stable.
Fixes #40724.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/40724#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list