[wp-trac] [WordPress Trac] #40702: Add WordCamps and meetup events to the News Dashboard widget

[WordPress Trac]

#40702: Add WordCamps and meetup events to the News Dashboard widget
--------------------------------------+-----------------------------------
 Reporter:  iandunn                   |       Owner:
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  4.8
Component:  Administration            |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  javascript, rest-api
--------------------------------------+-----------------------------------

Comment (by iandunn):

 Thanks for the feedback @ocean90 :)

 These ones are fixed in `40702.5.diff`:

 > * There should be no need to have .rtl classes in dashboard.css. The
 build task generates a dashboard-rtl.css file automatically.
 > * A few cases of esc_html_e() should be replaced with _e().
 > * HTML around placeholders like <strong>%s</strong> should be moved into
 the argument.
 > * DocBlocks should use third-person singular verbs
 > * get_community_events_script_data() should get the wp_ prefix.
 > * aren\'t should be are’t
 ----

 I need some more feedback on these:

 > It seems like inet_ntop() isn't available on PHP < 5.3 on Windows
 platforms.

 `maybe_anonymize_ip_address()` returns early if either of them don't
 exist. Do you see any cases where that won't avoid the problem?
 [[br]]

 > Let's not introduce wp_get_nearby_events(), you could check the global
 $wp_version instead.

 Do you mean update the plugin to check `$wp_version` during its bootstrap?
 Wouldn't that would require everyone whos running the plugin to update to
 the latest version before they upgrade to `4.8`? Since we can't guarantee
 that they will, it seems like that would introduce the chance for fatal
 errors.

 Although, the upgrade routine also deactivates the plugin, just to be
 safe, so maybe that's enough? What do you think?
 [[br]]

 > the URL should be a separate string and the placeholder needs a
 translator comment.

 Do you mean like this?

 {{{
 <?php printf(
         /* translators: %1$s is the city the user searched for; %2$s is a
 wordpress.org URL with locale-specific instructions for organizing a
 meetup. */
         __( 'There aren’t any events scheduled near %1$s at the
 moment. Would you like to <a href="%2$s">organize one</a>?' ),
         '{{data.location.description}}',
         /* translators: Replace the URL if a locale-specific one exists */
         __( 'https://make.wordpress.org/community/handbook/meetup-
 organizer/welcome/' )
 ); ?>
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40702#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform