[wp-trac] [WordPress Trac] #29872: Permalink Structure Tags buttons

WordPress Trac noreply at wordpress.org
Mon May 8 18:40:29 UTC 2017


#29872: Permalink Structure Tags buttons
-------------------------------------------------+-------------------------
 Reporter:  Apiweb                               |       Owner:  swissspidy
     Type:  feature request                      |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.8
Component:  Permalinks                           |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-ui-feedback has-patch needs-     |     Focuses:  ui,
  testing                                        |  accessibility
-------------------------------------------------+-------------------------

Comment (by swissspidy):

 I'm working on a refreshed patch to address the above feedback.

 > Then, when operating on the buttons, any content will be cleared out and
 the new tag inserted. This may not be the desired result, so maybe
 consider to add a tag at the end by default?

 I found this feature to be handy when you want to replace existing tags or
 add yours at some specific position. For example, when you put the cursor
 to the beginning of the input and click on a button, the tag will be
 inserted at the beginning. I added that based on earlier feedback by
 @joedolson:

 > 1) Ability to place cursor between items and insert new structure in
 that location instead of end

 However, I can remove that selection feature if it doesn't make much
 sense.

 -----

 > When a tag is already present in the structure, the related button does
 nothing and that's correct. However, there's nothing that can inform users
 the button won't produce any effect. Maybe, the buttons representing
 already inserted tags should also look differently.

 I have that "Already used" thing working, but I was wondering if we should
 just disable a button when the tag was inserted. VoiceOver doesn't
 announce the buttons anymore in that case and you already have the
 different styling. Also, @joedolson said this earlier:

 > 2) Avoid adding the same structure twice if clicked twice? Should a
 second click remove that structure from the string?

 -----

 > at least one -> at least once. ?

 Where did you see that, @afercia?

 ----

 > users should understand immediately what they are, so maybe style them
 as standard buttons?

 Makes sense.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29872#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list