[wp-trac] [WordPress Trac] #39686: Upgrade MediaElement to 4.X
WordPress Trac
noreply at wordpress.org
Sat May 6 17:21:20 UTC 2017
#39686: Upgrade MediaElement to 4.X
-------------------------------------+-------------------------
Reporter: rafa8626 | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 4.8.1
Component: External Libraries | Version: 4.7.1
Severity: normal | Resolution:
Keywords: has-patch needs-refresh | Focuses: javascript
-------------------------------------+-------------------------
Comment (by timmydcrawford):
Sorry for not adding some detailed instructions to my prior report. The
issue we are experiencing is related to the current version of
mediaelement which in trunk appears to be 2.22.0 - at least that is what
is output when I type {{{mejs.version}}} in the browser console.
The Media Video Widget uses {{{wp_video_shortcode}}}, which for a YouTube
video url, outputs the following in the DOM:
{{{
<div style="width:100%;" class="wp-video"><video class="wp-video-
shortcode" id="video-1-6" preload="metadata" controls="controls">
<source type="video/youtube"
src="https://www.youtube.com/watch?v=b5Qh72h8vkk&_=6" /><a
href="https://www.youtube.com/watch?v=b5Qh72h8vkk">https://www.youtube.com/watch?v=b5Qh72h8vkk</a></video>
</div>
}}}
From there mejs takes over. The corresponding mejs bug is detailed here
https://github.com/mediaelement/mediaelement/issues/1851 and was fixed
subsequently in https://github.com/instructure/mediaelement/pull/17. The
bug fix was released in version 2.23.2 per
https://github.com/instructure/mediaelement/blob/master/changelog.md
To see the bug happen, take the HTML above which is output from
{{{wp_video_shortcode}}}, and drop it into a text widget on a site running
trunk. Then view the output widget, click play - let it play to the end,
and note that the video loops. I attempted to fix by adding a
{{{loop=0}}} to the embed url, which YouTube supports, but the bug is in
medialement itself it seems.
Let me know if I can provide any more details
--
Ticket URL: <https://core.trac.wordpress.org/ticket/39686#comment:35>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list