[wp-trac] [WordPress Trac] #40589: Media: Replace button enabled when no media item selected
WordPress Trac
noreply at wordpress.org
Mon May 1 14:26:58 UTC 2017
#40589: Media: Replace button enabled when no media item selected
-------------------------------------------------+-------------------------
Reporter: timmydcrawford | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting
Component: Media | Review
Severity: normal | Version: trunk
Keywords: has-patch needs-testing has- | Resolution:
screenshots | Focuses: javascript
-------------------------------------------------+-------------------------
Comment (by adamsilverstein):
@psiico
Thanks for your work and patch here, and for providing the screencast.
We don't need to track selection in the click callback because the toolbar
component already supports a `section: required` attribute that produces
the desired behavior.
[attachment:40589.2.diff] is an alternate approach that uses that feature.
Can you please test? Thanks.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/40589#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list