[wp-trac] [WordPress Trac] #39301: Importer associates all posts with uncategorized term in WP4.7 PHP7

WordPress Trac noreply at wordpress.org
Thu Mar 30 16:59:47 UTC 2017


#39301: Importer associates all posts with uncategorized term in WP4.7 PHP7
--------------------------+------------------------------
 Reporter:  staymanhou    |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Import        |     Version:  4.7
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  administration
--------------------------+------------------------------

Comment (by mcbsys):

 @lukecavanagh Reviewing your edits Github, it looks like both edits were
 inserted above where @staymanhou suggested.

 The first edit almost certainly needs to go ''after'' `$term['domain']` is
 set, i.e. after line 729.

 The second edit is suggested after line 753. You've got it inside the
 `foreach` instead of after the `unset( $post['terms'], $terms_to_set );`.

 Also, not that familiar with Github processes but this pull request says
 shows up under "Replace use of wp_get_http()".  Shouldn't it be separate?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39301#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list