[wp-trac] [WordPress Trac] #40292: Twenty Seventeen: Use echo file_get_contents() instead of require_once() to pull in SVG file contents

WordPress Trac noreply at wordpress.org
Wed Mar 29 11:29:25 UTC 2017


#40292: Twenty Seventeen: Use echo file_get_contents() instead of require_once() to
pull in SVG file contents
---------------------------+------------------------------
 Reporter:  kellenmace     |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Bundled Theme  |     Version:  4.7.3
 Severity:  normal         |  Resolution:
 Keywords:                 |     Focuses:
---------------------------+------------------------------

Comment (by sami.keijonen):

 > could be better because it will suppress error.

 Just noting that there is no error in Twenty17. But because code probably
 get copied a lot without thinking `readfile()` makes sense if in other
 theme there is using `<?xml`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40292#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list