[wp-trac] [WordPress Trac] #39087: Customizer: Add indicator when additional widget areas are hidden

WordPress Trac noreply at wordpress.org
Wed Mar 22 20:56:45 UTC 2017


#39087: Customizer: Add indicator when additional widget areas are hidden
-------------------------------------------------+-------------------------
 Reporter:  shireling                            |       Owner:
     Type:  enhancement                          |  westonruter
 Priority:  normal                               |      Status:  reopened
Component:  Customize                            |   Milestone:  4.7.4
 Severity:  normal                               |     Version:  3.9
 Keywords:  has-ux-feedback has-patch needs-     |  Resolution:
  testing has-screenshots i18n-change            |     Focuses:
-------------------------------------------------+-------------------------

Comment (by westonruter):

 Replying to [comment:35 ocean90]:
 > I agree that using `p.html( string )` should be avoided but wouldn't
 `html_entity_decode()` help here? We did the same in [32885] and [32822].

 Apparently it does work: [attachment:39087.8.diff] [https://github.com/xwp
 /wordpress-develop/pull/220 PR]

 I was somewhat fuzzy on what would happen on a site that uses a non-UTF8
 charset, with that data getting passed passed into `wp_json_encode()`
 since `json_encode()` requires UTF-8. But I suppose then this is what
 `wp_json_encode()` fixes in its calls to `_wp_json_convert_string()`?

 All that being said, does [attachment:39087.8.diff] get a +1 for 4.7.4?

 Aside: To me it seems `APOSTROPHE (U+0027)` is still better (more
 semantic) to use for apostrophes than `LEFT SINGLE QUOTATION MARK
 (U+2018)`. But I suppose that's just my opinion.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39087#comment:36>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list