[wp-trac] [WordPress Trac] #40152: Crop Image button off-screen on mobile

[WordPress Trac]

#40152: Crop Image button off-screen on mobile
--------------------------------------+---------------------------------
 Reporter:  Cybr                      |       Owner:
     Type:  defect (bug)              |      Status:  reopened
 Priority:  normal                    |   Milestone:  4.7.4
Component:  Media                     |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:  ui, administration
--------------------------------------+---------------------------------

Comment (by Cybr):

 Replying to [comment:9 adamsilverstein]:
 > @Cybr I don't quite understand your comment, what do you mean by " if
 div with class `media-toolbar-secondary` is filled in with anything", can
 you give an example or steps to reproduce?

 I can't give you an example, because I don't really understand the correct
 structure for third party implementation on this part.

 However, what I do know is that there are two div elements inside `.media-
 frame-toolbar > .media-toolbar`:

 {{{
 <div class="media-frame-toolbar">
         <div class="media-toolbar">
                 <div class="media-toolbar-secondary"></div>
                 <div class="media-toolbar-primary search-form">
                         <button type="button" class="button media-button
 button-secondary button-large media-button-skip">Skip Cropping</button>
                         <button type="button" class="button media-button
 button-primary button-large media-button-insert">Crop Image</button>
                 </div>
         </div>
 </div>
 }}}

 When you fill in `.media-toolbar-secondary` with any flow-forming content
 (like text), and set `.media-toolbar-primary` to 100%, then `media-
 toolbar-primary` will overflow.
 This is because `media-toolbar-secondary` is output first (i.e. it should
 be the 67% of the left side).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40152#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform