[wp-trac] [WordPress Trac] #40224: Twenty Seventeen: navigation.js should be enqueued with jQuery as dependency

[WordPress Trac]

#40224: Twenty Seventeen: navigation.js should be enqueued with jQuery as
dependency
-------------------------------------+--------------------
 Reporter:  chesio                   |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  4.7.4
Component:  Bundled Theme            |     Version:  4.7
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:
-------------------------------------+--------------------
Changes (by peterwilsoncc):

 * keywords:   => has-patch needs-refresh
 * version:  trunk => 4.7
 * milestone:  Awaiting Review => 4.7.4


Comment:

 @chesio,

 Thanks for providing the patch.

 Although the patch works, it doesn't meet the
 [https://make.wordpress.org/core/handbook/best-practices/coding-
 standards/php/ WordPress PHP coding standards] which require spaces inside
 the brackets, ie `array( 'jquery' )`. The coding standards are in place to
 make reading the code easier for future developers.

 I've marked the patch as needing a refresh and to be fixed in the next
 release.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40224#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform