[wp-trac] [WordPress Trac] #40185: Add opens in a new window to the Preview link

WordPress Trac noreply at wordpress.org
Sat Mar 18 14:21:22 UTC 2017


#40185: Add opens in a new window to the Preview link
-------------------------------------------------+-------------------------
 Reporter:  rianrietveld                         |       Owner:
     Type:  defect (bug)                         |  rianrietveld
 Priority:  normal                               |      Status:  assigned
Component:  Administration                       |   Milestone:  4.8
 Severity:  normal                               |     Version:
 Keywords:  target-blank has-patch needs-        |  Resolution:
  refresh                                        |     Focuses:
                                                 |  accessibility
-------------------------------------------------+-------------------------

Comment (by SergeyBiryukov):

 Minor nitpicking: `sprintf()` arguments generally don't need a lot of tabs
 or spaces for alignment, this should be enough:
 {{{
 $preview_button = sprintf( '%1$s<span class="screen-reader-text">
 %2$s</span>',
         esc_html( $preview_button_text ),
         /* translators: accessibility text */
         esc_html__( '(link opens in a new window)' )
 );
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40185#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list