[wp-trac] [WordPress Trac] #35105: Specifiy minimum node and npm version in package.json
WordPress Trac
noreply at wordpress.org
Sun Mar 12 22:31:28 UTC 2017
#35105: Specifiy minimum node and npm version in package.json
------------------------------+-----------------------
Reporter: jorbin | Owner: ocean90
Type: task (blessed) | Status: accepted
Priority: normal | Milestone: 4.8
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: has-patch commit | Focuses:
------------------------------+-----------------------
Comment (by netweb):
Replying to [comment:36 ocean90]:
> @netweb Looks like Node 4.7.2 doesn't work for the 4.2 branch: https
://travis-ci.org/aaronjorbin/develop.wordpress/jobs/210162438. Neither
does [https://travis-ci.org/ocean90/develop.wordpress/builds/210237363
4.5.0] or [https://travis-
ci.org/ocean90/develop.wordpress/builds/210238841 6.9.1]. But [https
://travis-ci.org/ocean90/develop.wordpress/builds/210240331 0.12.18]
works.
Cool, let's go with 0.12.x then
Replying to [comment:36 ocean90]:
> Looking at https://travis-ci.org/aaronjorbin/develop.wordpress/branches,
all the failed builds seem to be unrelated to the node version so I think
we can stick with the node version which Travis is currently using.
Up until these recent commits being merged we weren't able to determine if
the builds were passing or failing as the jobs were reporting `errrored`
by Travis before PHPUnit or the JS Grunt tasks could be run, everything
would error before any testing would commence.
The NodeJS versions I chose were an attempt to mimic the timeline of
core's releases to the timeline of the NodeJS releases aiming for some
glimmer of hope of compatibility with the branches `package.json` files
/shrug
I'm travelling for the remainder of today, I can take a look at updating a
patch and testing tomorrow if no one beats me to it
--
Ticket URL: <https://core.trac.wordpress.org/ticket/35105#comment:37>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list