[wp-trac] [WordPress Trac] #40047: Add term_meta to WP_Term class getter method

WordPress Trac noreply at wordpress.org
Sun Mar 12 19:14:53 UTC 2017


#40047: Add term_meta to WP_Term class getter method
-----------------------------------+------------------------------
 Reporter:  barryceelen            |       Owner:
     Type:  enhancement            |      Status:  new
 Priority:  normal                 |   Milestone:  Awaiting Review
Component:  Taxonomy               |     Version:  trunk
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+------------------------------
Changes (by boonebgorges):

 * keywords:  has-patch => has-patch 2nd-opinion


Comment:

 Thanks for the ticket and the patch, @barryceelen.

 I intentionally left this feature out of the initial implementation of
 `WP_Term` because I find it odd. It has the potential to cause arbitrary
 backward compatibility problems, in the case where core wants to introduce
 a class property that matches a meta key in use by a plugin. It looks like
 @nacin independently thought something similar about `WP_Comment` (where
 there's also no meta support of this type):
 https://core.trac.wordpress.org/ticket/32619#comment:6

 Is there a strong argument in favor of including it here and on comments?
 Or is it primarily for the (very) minor convenience, as well as
 consistency with user and post objects?

 cc @flixos90, who mentioned this issue during `WP_Term` development, but
 whose comment I carefully ignored at the time :)
 https://core.trac.wordpress.org/ticket/14162#comment:21 I vaguely recall
 having a conversation with him about this, which may be somewhere in the
 Slack archives.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40047#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list