[wp-trac] [WordPress Trac] #39367: Don't no-op $user_id in test suite's wp_set_auth_cookie()

[WordPress Trac]

#39367: Don't no-op $user_id in test suite's wp_set_auth_cookie()
-----------------------------------+--------------------------
 Reporter:  danielbachhuber        |       Owner:  johnbillion
     Type:  defect (bug)           |      Status:  closed
 Priority:  normal                 |   Milestone:  4.7.4
Component:  Build/Test Tools       |     Version:  4.7
 Severity:  normal                 |  Resolution:  fixed
 Keywords:  has-patch fixed-major  |     Focuses:
-----------------------------------+--------------------------
Changes (by johnbillion):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"40265"]:
 {{{
 #!CommitTicketReference repository="" revision="40265"
 Build/Test tools: Don't override the `wp_set_auth_cookie()` and
 `wp_clear_auth_cookie()` functions.

 Overriding pluggable functions in the test suite is asking for trouble in
 the future. In addition, it means the test suite can't be guaranteed to
 behave the same as core.

 This instead introduces a `send_auth_cookies` filter which can be hooked
 in during the test suite to prevent these functions from attempting to
 send cookie headers to the client.

 Fixes #39367

 Merges [40263] and [40264]  to the 4.7 branch.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39367#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform