[wp-trac] [WordPress Trac] #31779: Warn users before using a built-in file editor for the first time

WordPress Trac noreply at wordpress.org
Tue Mar 7 20:06:20 UTC 2017


#31779: Warn users before using a built-in file editor for the first time
----------------------------------------+---------------------------------
 Reporter:  helen                       |       Owner:  helen
     Type:  enhancement                 |      Status:  reviewing
 Priority:  normal                      |   Milestone:  Awaiting Review
Component:  Themes                      |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  good-first-bug needs-patch  |     Focuses:  ui, administration
----------------------------------------+---------------------------------

Comment (by ZaneMatthew):

 Is the patch still valid?

 When applying the patch via
 {{{
 grunt patch:31779
 }}}

 I'm getting the following;

 {{{#!php
 <?php
 Running "patch:31779" (patch) task
 ? Please select a patch to apply 31779-33.diff (52.0 KB) - added by
 aryamaaru 4 months ago.
 patching file wp-admin/themes.php
 Hunk #1 FAILED at 158.
 1 out of 1 hunk FAILED -- saving rejects to file wp-admin/themes.php.rej
 patching file wp-admin/theme-editor.php
 patching file wp-admin/js/theme.js
 Hunk #1 FAILED at 83.
 1 out of 1 hunk FAILED -- saving rejects to file wp-admin/js/theme.js.rej
 can't find file to patch at input line 58
 Perhaps you used the wrong -p or --strip option?
 The text leading up to this was:
 --------------------------
 |Index: wp-admin/js/theme.min.js
 |===================================================================
 |--- wp-admin/js/theme.min.js   (revision 38598)
 |+++ wp-admin/js/theme.min.js   (working copy)
 --------------------------
 File to patch:
 Skip this patch? [y] y
 Skipping patch.
 1 out of 1 hunk ignored

 Done, without errors
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31779#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list