[wp-trac] [WordPress Trac] #39222: Add JavaScript date helpers
WordPress Trac
noreply at wordpress.org
Tue Mar 7 13:14:28 UTC 2017
#39222: Add JavaScript date helpers
---------------------------------------------------+-----------------------
Reporter: rmccue | Owner: rmccue
Type: feature request | Status: assigned
Priority: normal | Milestone: 4.8
Component: Date/Time | Version: 4.7
Severity: normal | Resolution:
Keywords: has-patch needs-unit-tests needs-docs | Focuses: rest-api
---------------------------------------------------+-----------------------
Comment (by nerrad):
Looks great! Glad to see the decision to go with moment - it definitely
removes much of the extra work that would have been done.
To echo @flixos90 and confirm the approach, I've done mapping of formats
similarly in other projects as well.
Within the mapping, should the `dateMoment` argument be clarified in
jsdocs so that its clear it is expecting a moment date object? maybe even
rename the variable to `dateMoment` so its extra clear?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/39222#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list