[wp-trac] [WordPress Trac] #36613: Browser back button doesn't work in Theme Browser

[WordPress Trac]

#36613: Browser back button doesn't work in Theme Browser
-------------------------------------+------------------------------
 Reporter:  dd32                     |       Owner:  adamsilverstein
     Type:  defect (bug)             |      Status:  reopened
 Priority:  normal                   |   Milestone:  4.8
Component:  Themes                   |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  needs-testing has-patch  |     Focuses:  javascript
-------------------------------------+------------------------------

Comment (by afercia):

 @adamsilverstein finally tested a bit, yep previous error seems gone.
 However, there are still edge cases where seems it's a bit difficult to
 make the history work correctly. To reproduce one of these cases:
 - start from the Popular tab (`?browse=popular`)
 - click on the second theme
 - the installer opens, navigate 2 themes forward
 - click on the browser's Back button three times, and the installer closes
 - you're back on the Popular tab
 - notice your browser's Forward button is disabled, maybe should keep the
 forward history
 - notice in the browser address bar `?browse=popular` is gone

 Now start a new theme navigation:
 - click on the third theme
 - the installer opens, navigate 2 themes forward
 - click on the browser's back three times, and the installer closes
 - you're now on the Featured tab, you should be on the Popular one
 - notice your browser's Forward button is enabled and clickable
 - click on the browser's Forward button
 - the address bar gets updated with the last theme displayed parameter
 `?theme=themename`
 - nothing happens but you get a JS error `Cannot read property 'toJSON' of
 undefined`
 - refresh the page, and the theme installer opens

 I ''think'' some of the issues come from underlying issues in the theme
 installer, but haven't looked in depth.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36613#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform