[wp-trac] [WordPress Trac] #40010: Regression for #36749. Uploading an image into site_icon breaks customizer

[WordPress Trac]

#40010: Regression for #36749. Uploading an image into site_icon breaks customizer
--------------------------+-----------------------------
 Reporter:  aussieguy123  |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  General       |    Version:  trunk
 Severity:  normal        |   Keywords:
  Focuses:                |
--------------------------+-----------------------------
 Looks like #36749 has shown itself again in the latest core commits.

 I've attached a patch, which fixes this issue.

 Seems that the template is not checking if data.attachment.sizes.full
 exists before printing out  data.attachment.sizes.full.url. This causes a
 console error (trying to get property url from a non-object).

 To reproduce:

 - Open Customizer
 - Under site identity upload an image
 - Publish
 - Refresh the page

 Expected:
 Page loads normally with new icon

 Actual:
 Page partially loads, customizer is broken

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40010>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform