[wp-trac] [WordPress Trac] #41216: Avoid using 'http://localhost/foo-cropped.png' in tests

WordPress Trac noreply at wordpress.org
Fri Jun 30 19:24:56 UTC 2017


#41216: Avoid using 'http://localhost/foo-cropped.png' in tests
-----------------------------+-----------------------------
 Reporter:  danielbachhuber  |      Owner:
     Type:  defect (bug)     |     Status:  new
 Priority:  normal           |  Milestone:  Awaiting Review
Component:  Media            |    Version:
 Severity:  normal           |   Keywords:  needs-patch
  Focuses:                   |
-----------------------------+-----------------------------
 Two image header tests use a `http://localhost/foo-cropped.png` value:

 * `Tests_Image_Header::test_create_attachment_object`
 * `Tests_Image_Header::test_insert_cropped_attachment`

 In some system configurations, this can cause ImageMagick to throw an
 exception:

 {{{
 ImagickException: getimagesize(http://localhost/foo-cropped.png): failed
 to open stream: Connection refused
 }}}

 This was originally added in r27847. In skimming through #21785, it
 doesn't appear to be a deliberate decision to use `http://localhost/foo-
 cropped.png`. It would be better to use a value that doesn't trigger an
 outbound HTTP request.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41216>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list