[wp-trac] [WordPress Trac] #40780: Update docblocks & parameters in wp-includes/link-template.php for post-related functions

WordPress Trac noreply at wordpress.org
Fri Jun 30 15:21:43 UTC 2017


#40780: Update docblocks & parameters in wp-includes/link-template.php for post-
related functions
-------------------------------+------------------------------
 Reporter:  GunGeekATX         |       Owner:
     Type:  enhancement        |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Posts, Post Types  |     Version:  4.8
 Severity:  normal             |  Resolution:
 Keywords:  needs-refresh      |     Focuses:  docs
-------------------------------+------------------------------
Changes (by adamsilverstein):

 * keywords:   => needs-refresh


Comment:

 Overall this makes sense, however, I don't think `get_post_permalink`
 actually accepts a post object currently.

 In your change at line 267, you call `get_post_status` with a WP_Post
 object, but that function takes a post ID - maybe change to `$post->ID`?
 Also I want to make sure the $id isn't used elsewhere.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40780#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list