[wp-trac] [WordPress Trac] #41123: Modified `WP_TESTS_TITLE` causes dirty wp-api-generated.js

WordPress Trac noreply at wordpress.org
Thu Jun 29 13:51:59 UTC 2017

#41123: Modified `WP_TESTS_TITLE` causes dirty wp-api-generated.js
 Reporter:  boonebgorges  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  REST API      |     Version:  4.7
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:

Comment (by jnylen0):

 When a change is made to the REST API there should be some indication that
 this fixture file needs to be updated as well.  Currently that shows up as
 the file being regenerated with changes and marked as dirty.  It could
 also be a failing test or something like that - this setup has gotten a
 bit complicated and could use some re-working.

 [attachment:41123.diff] should fix the issue for now.  We need to add some
 lines to
 /rest-api/rest-schema-setup.php?marks=381-452#L375 this code block] which
 protects parts of the fixture file against changes that can happen in
 between PHPUnit runs.  Here are the
 [https://core.trac.wordpress.org/ticket/39264#comment:29 steps originally
 used to generate it].

 Should we also guard against changes to `WP_TESTS_DOMAIN` and
 `WP_TESTS_EMAIL`?  In particular, changing `WP_TESTS_DOMAIN` causes a lot
 more changes to the fixture file.

Ticket URL: <https://core.trac.wordpress.org/ticket/41123#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list