[wp-trac] [WordPress Trac] #32228: "Page updated" notification should fade as soon as another change is made.

WordPress Trac noreply at wordpress.org
Mon Jun 26 18:22:13 UTC 2017


#32228: "Page updated" notification should fade as soon as another change is made.
-------------------------------------------------+-------------------------
 Reporter:  nthnldtk                             |       Owner:  italianst4
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  Awaiting
Component:  Editor                               |  Review
 Severity:  normal                               |     Version:
 Keywords:  ux-feedback good-first-bug has-      |  Resolution:
  patch needs-testing                            |     Focuses:
                                                 |  administration
-------------------------------------------------+-------------------------

Comment (by juanfra):

 Nice one!

 Please take a look that the "just now" message is not translatable. Also
 for the "Post updated" message you shouldn't concatenate the strings, you
 never know how other languages manage the same sentence.

 I'd do something like this:


 {{{
 $saved_timeago = ' <em><abbr title="' . date( 'c', current_time(
 'timestamp' ) ) . '" class="xwp-ui-text-icon timeago"> . __( 'just now' )
 . '</abbr></em>';
 }}}

 Perhaps even using kses, and bringing up that string in a better way.

 And then for the `$messages['post']` array:

 {{{
 1 => sprintf( __( 'Post updated %s' ), $saved_timeago ) .
 $view_post_link_html;
 }}}

 Cheers

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32228#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list