[wp-trac] [WordPress Trac] #41121: Consistency of the _deprecated_function() calls and related documentation.

[WordPress Trac]

#41121: Consistency of the _deprecated_function() calls and related documentation.
----------------------------+---------------------------
 Reporter:  jrf             |       Owner:  DrewAPicture
     Type:  task (blessed)  |      Status:  reviewing
 Priority:  normal          |   Milestone:  4.9
Component:  General         |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  docs
----------------------------+---------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:10 jrf]:
 > I've based my usage of escaped quotes on the precedent for this as set
 in numerous other function calls to `_deprecated_function()`, though there
 is no real consensus as current usage is inconsistent.

 All of those cases are pieces of code, not strings. In this case, we're
 trying to slot some hardcoded English text into a translatable string,
 which seems less than ideal and doesn't have a precedent AFAIK.

 With `_deprecated_function( __METHOD__, '4.2.0',
 'customize_dynamic_setting_args' )`, the resulting message would include
 `Use 'customize_dynamic_setting_args' instead`, which seems clear enough.
 It's a developer notice, and developers should be able to figure out that
 it's a filter, not a function.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41121#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform