[wp-trac] [WordPress Trac] #41081: Improve Custom Menu widget, show notification if menu is empty or no menu selected

WordPress Trac noreply at wordpress.org
Wed Jun 21 19:10:26 UTC 2017


#41081: Improve Custom Menu widget, show notification if menu is empty or no menu
selected
---------------------------------------------+-----------------------------
 Reporter:  alexvorn2                        |       Owner:
     Type:  enhancement                      |      Status:  new
 Priority:  normal                           |   Milestone:  4.9
Component:  Widgets                          |     Version:  trunk
 Severity:  normal                           |  Resolution:
 Keywords:  good-first-bug has-patch commit  |     Focuses:  administration
---------------------------------------------+-----------------------------
Changes (by welcher):

 * keywords:  good-first-bug has-patch needs-refresh => good-first-bug has-
     patch commit
 * milestone:  Awaiting Review => 4.9


Comment:

 Replying to [comment:6 mdifelice]:
 > Hi @welcher. Just sent it. I am pretty new with contributing with the
 WordPress core, so sorry if I do not follow certain conventions. I was not
 sure if using the filename or ticket number for the attachment, finally I
 used the ticket number since I saw a lot of other attachments that do it
 that way.

 @mdifelice no worries at all! Thank you for taking the time to contribute
 - we all have to start somewhere! It looks like you generated it from the
 `/src` dir. If we generate from one level higher, we'll get any changes to
 the `/tests` folder ( and other items ) as well.

 I've added some updates to the messaging when the there are no menus found
 to better reflect the changes in this patch. Unit tests pass with this
 patch.

 I think we're good to go!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41081#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list