[wp-trac] [WordPress Trac] #41039: `_delete_option_fresh_site()` continually queries the database

[WordPress Trac]

#41039: `_delete_option_fresh_site()` continually queries the database
-----------------------------+-----------------------------
 Reporter:  dlh              |      Owner:
     Type:  defect (bug)     |     Status:  new
 Priority:  normal           |  Milestone:  Awaiting Review
Component:  Upgrade/Install  |    Version:  4.7
 Severity:  normal           |   Keywords:
  Focuses:                   |
-----------------------------+-----------------------------
 `_delete_option_fresh_site()` passes the integer `0` to `update_option()`,
 but `0` will later be fetched from the database as the string `'0'`.

 Each time `_delete_option_fresh_site()` is called, then, when
 `update_option()` checks whether the new value is the same as the current
 value, it will see the two values as different and attempt to perform the
 database update.

 The attached patch would instead pass the string `'0'` to
 `update_option()`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41039>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform