[wp-trac] [WordPress Trac] #40977: Widgets: Query param for `loop` added for non-hosted external videos

WordPress Trac noreply at wordpress.org
Fri Jun 9 13:59:27 UTC 2017


#40977: Widgets: Query param for `loop` added for non-hosted external videos
--------------------------+--------------------
 Reporter:  westonruter   |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.8.1
Component:  Widgets       |     Version:  4.8
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+--------------------
Description changed by westonruter:

Old description:

> When embedding an external video file into a video widget, the video
> shortcode is currently failing to render the video due to the erroneous
> injection of a `loop` query parameter. The `loop` parameter was
> specifically added to work around a Vimeo issue, but the logic was not
> properly restricted to only effect Vimeo URLs. For more background, see
> https://github.com/xwp/wordpress-develop/pull/232#issuecomment-306861073

New description:

 When embedding an external video file into a video widget, the video
 shortcode is currently failing to render the video due to the erroneous
 injection of a `loop` query parameter. The `loop` parameter was
 specifically added to work around a Vimeo issue, but the logic was not
 properly restricted to only effect Vimeo URLs. For more background, see
 https://github.com/xwp/wordpress-develop/pull/232#issuecomment-306861073

 Note that the need for the `loop` parameter will be eliminated once the
 upgrade to ME.js 4.x is done. See #39686.

--

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40977#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list