[wp-trac] [WordPress Trac] #40935: Facebook Video Works On Preview But Not On Theme

[WordPress Trac]

#40935: Facebook Video Works On Preview But Not On Theme
--------------------------+--------------------
 Reporter:  emanweb       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.8.1
Component:  Widgets       |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+--------------------
Changes (by westonruter):

 * keywords:   => needs-patch
 * milestone:  Awaiting Review => 4.8.1


Comment:

 This is a bug. Only YouTube and Vimeo are supposed to have been
 acceptable.

 The video widget somehow needs to extend the [https://github.com/WordPress
 /wordpress-develop/blob/4379d2ff69262c3270fd907a651af466d60b904e/src/wp-
 admin/js/widgets/media-widgets.js#L142-L209 fetch logic] to take into
 account [https://github.com/WordPress/wordpress-
 develop/blob/4379d2ff69262c3270fd907a651af466d60b904e/src/wp-
 admin/js/widgets/media-video-widget.js#L137-L147 isHostedVideo], perhaps.
 There could perhaps be a new `MediaWidgetControl#isAllowedUrl()` which by
 default returns `true`, or rather it should include the
 [https://github.com/WordPress/wordpress-
 develop/blob/4379d2ff69262c3270fd907a651af466d60b904e/src/wp-
 admin/js/widgets/media-widgets.js#L172-L179 specific logic] in the `fetch`
 method. Then the video widget specifically can extend that `isAllowedUrl`
 method to take into account `isHostedVideo`. Since oEmbed is not supported
 by the audio widget at all, then it should bail entirely if the URL is not
 for an audio file.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40935#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform