[wp-trac] [WordPress Trac] #40188: Filter button should not appear when no comments are available in list

WordPress Trac noreply at wordpress.org
Tue Jun 6 05:00:13 UTC 2017


#40188: Filter button should not appear when no comments are available in list
--------------------------------------+---------------------------------
 Reporter:  swissspidy                |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Comments                  |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:  ui, administration
--------------------------------------+---------------------------------

Comment (by menakas):

 A thought, though I haven't deep dived into the code to find its
 feasibility:

 //Maybe there are other list tables that might need to be checked as
 well.//

 @swissspidy concern is valid. This is a feature common to all list tables
 (WP_List_Table) i.e, all lists should display the Filter option if and
 only if there is at least one list item.

 In fact, in the comments list table, this functionality should reflect in
 all sub lists - All, Pending, Approved, Spam and Trash. Likewise, in other
 lists like posts, categories, tags and so on.

 With this in mind, a solution at the WP_List_Table class level would be
 better.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40188#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list