[wp-trac] [WordPress Trac] #40829: Improve wp_dropdown_languages() so it doesn't print out empty attributes
WordPress Trac
noreply at wordpress.org
Thu Jun 1 23:37:45 UTC 2017
#40829: Improve wp_dropdown_languages() so it doesn't print out empty attributes
-------------------------------------+-----------------------------
Reporter: afercia | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: I18N | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-refresh | Focuses:
-------------------------------------+-----------------------------
Comment (by johnjamesjacoby):
Replying to [comment:2 ocean90]:
> Let's not change `$args` to `$r`, that's not really relevant for this
change.
It will be relevant when there's a variable collision, and it's already a
commonly used approach in core.
This is still a bug, because form elements cannot have empty names.
Leaving `wp_dropdown_languages()` as is increases the opportunity for it
to introduce more problems, as this ticket discovered already.
Why not just fix this now and move onto bigger things? This should be
committed as patched, not moved into the Future Release abyss.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/40829#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list