[wp-trac] [WordPress Trac] #40205: Interim login modal window uses front end language instead of admin language

WordPress Trac noreply at wordpress.org
Mon Jul 31 17:55:35 UTC 2017


#40205: Interim login modal window uses front end language instead of admin
language
-----------------------------------------+-----------------------------
 Reporter:  johnbillion                  |       Owner:
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  Future Release
Component:  I18N                         |     Version:  4.7
 Severity:  normal                       |  Resolution:
 Keywords:  needs-screenshots has-patch  |     Focuses:  administration
-----------------------------------------+-----------------------------
Changes (by swissspidy):

 * keywords:  needs-patch needs-screenshots => needs-screenshots has-patch


Comment:

 Thanks for the patch!

 A few notes:

 * I think `switch_to_locale()` should happen before the `login_init`
 action fires.
 * Should we add a `restore_previous_locale()` call for consistency? (only
 if `switch_to_locale()` returns true)
 * `sanitize_text_field()` should be fine. `switch_to_locale()` bails early
 when the locale is not invalid.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40205#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list