[wp-trac] [WordPress Trac] #41417: Error when opening up Thickbox lightbox on plugins page

[WordPress Trac]

#41417: Error when opening up Thickbox lightbox on plugins page
-----------------------------------------+-----------------------------
 Reporter:  moeloubani1                  |       Owner:  afercia
     Type:  defect (bug)                 |      Status:  assigned
 Priority:  normal                       |   Milestone:  4.9
Component:  Administration               |     Version:  4.5
 Severity:  normal                       |  Resolution:
 Keywords:  has-screenshots needs-patch  |     Focuses:  ui, javascript
-----------------------------------------+-----------------------------
Changes (by afercia):

 * keywords:  reporter-feedback => has-screenshots needs-patch
 * owner:   => afercia
 * version:  4.8 => 4.5
 * status:  new => assigned
 * milestone:  Awaiting Review => 4.9


Comment:

 Sure, see something, say something ;) And you're right. Seems Thickbox
 doesn't work well with inline content any longer. I can reproduce the
 error in the Plugins page when closing the Thickbox modal. In the plugins
 page, Thickbox is used in a very specific way by core, but that doesn't
 mean this shouldn't be fixed.

 To reproduce, just add this HTML in the plugins page:

 {{{
 <a href="#TB_inline?width=600&height=550&inlineId=my-hidden-content"
 class="thickbox">View my inline content!</a>
 <div id="my-hidden-content" style="display: none;"><p>Hello!</p></div><br>
 }}}

 - when the Thickbox modal opens, the inline content is displayed correctly
 but the loading spinner doesn't disappear
 - when closing the modal, there's a conflict with `plugin-install.js`
 where `$focusedBefore` is undefined.

 Not sure when the Thickbox inline content stopped working correctly. The
 part related to `$focusedBefore` was introduced in 4.5.

 [[Image(https://cldup.com/CZ51oXaesC.jpg)]]

 [[Image(https://cldup.com/i11I3axmvE.jpg)]]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41417#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform