[wp-trac] [WordPress Trac] #35959: Functon 'wp_generate_attachment_metadata(...)' silently swallowing errors from 'wp_get_image_editor(...)'.

WordPress Trac noreply at wordpress.org
Thu Jul 27 16:14:49 UTC 2017


#35959: Functon 'wp_generate_attachment_metadata(...)' silently swallowing errors
from 'wp_get_image_editor(...)'.
-------------------------------------------------+-------------------------
 Reporter:  maratbn                              |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  Media                                |  Review
 Severity:  normal                               |     Version:  3.5
 Keywords:  has-patch needs-refresh needs-       |  Resolution:
  testing                                        |     Focuses:
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * keywords:   => has-patch needs-refresh needs-testing


Comment:

 @maratbn Thanks for the ticket! Are you able to recreate the patch as a
 `.diff` or `.patch` file? See
 https://make.wordpress.org/core/handbook/contribute/#patches for help.

 There are also a few minor style issues in the patch. `if` statements
 should always contain braces, and inline control structures are prohibited
 (See https://make.wordpress.org/core/handbook/best-practices/coding-
 standards/php/#brace-style).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35959#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list