[wp-trac] [WordPress Trac] #41396: set_post_format: inconsistency between edit_post and bulk_edit_posts

[WordPress Trac]

#41396: set_post_format: inconsistency between edit_post and bulk_edit_posts
------------------------------+------------------
 Reporter:  Chouby            |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  4.9
Component:  Post Formats      |     Version:  3.3
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+------------------
Changes (by SergeyBiryukov):

 * keywords:  has-patch => has-patch commit


Comment:

 Simply moving `set_post_format()` call above `wp_update_post()` is not
 enough, as `wp_insert_post()` then [source:tags/4.8/src/wp-
 includes/post.php#L3343 overwrites the format] with the old data from
 `$post_data['tax_input']['post_format']`.

 [attachment:41396.2.diff] adds `unset(
 $post_data['tax_input']['post_format'] )` and a unit test.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41396#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform