[wp-trac] [WordPress Trac] #41394: Custom HTML widget applies widget_text filters with unexpected $instance data

[WordPress Trac]

#41394: Custom HTML widget applies widget_text filters with unexpected $instance
data
--------------------------+-------------------
 Reporter:  westonruter   |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  4.8.1
Component:  Widgets       |    Version:  trunk
 Severity:  normal        |   Keywords:
  Focuses:                |
--------------------------+-------------------
 The Custom HTML widget (#40907) applies the `widget_text` filters on its
 content to ensure that when a user moves HTML from a Text widget over to a
 Custom HTML widget, it will get all of the same filters applied. See
 [41086]. There are still `widget_text_content` and
 `widget_custom_html_content` filters that apply to the Text widget and
 Custom HTML widget respectively, but they share this same `widget_text`
 filter that has been around since WP 2.3.0.

 When the Custom HTML widget applies the `widget_text` filters, it is
 supplying the Custom HTML widget's `$instance` as the filter's second
 argument. This could cause problems for plugins that filter `widget_text`
 because they may expect a widget's instance data to look like:

 {{{#!json
 {
     "title": "The Title",
     "text": "Hell World",
     "filter": false
 }
 }}}

 When instead the Custom HTML widget instances look like:

 {{{#!json
 {
     "title": "The Title",
     "content": "Hell World"
 }
 }}}

 So in order to preserve backwards compatibility for plugins that look at
 the `$instance` param, the instance data needs to be transformed from the
 Custom HTML instance schema over to the Text widget instance schema.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41394>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform