[wp-trac] [WordPress Trac] #21170: JavaScript actions and filters

WordPress Trac noreply at wordpress.org
Thu Jul 20 22:33:45 UTC 2017


#21170: JavaScript actions and filters
-----------------------------+------------------------------
 Reporter:  koopersmith      |       Owner:  adamsilverstein
     Type:  feature request  |      Status:  assigned
 Priority:  normal           |   Milestone:  4.9
Component:  General          |     Version:  3.4
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:  javascript
-----------------------------+------------------------------
Changes (by jnylen0):

 * keywords:  commit has-patch => has-patch


Comment:

 In general this is a surprisingly complicated bit of code to get right.
 See https://github.com/WordPress/packages/pull/13#issuecomment-316843679
 for a (non-exhaustive) list of things that still need to be done.  It's
 roughly 1,000,000x easier to iterate on it in GitHub, so please comment on
 the specific approach there.

 Replying to [comment:129 azaozz]:
 > Are we adding support for "named" actions/filters: `addAction( 'tag.my-
 name', function() ... )` as per the last chat in #core-js? Thinking we
 should make that mandatory, i.e. all actions and filters will have to be
 "named" for easy interoperability.

 Yes, this needs to go in.

 However, I'm not sure we should make it mandatory.  And if we do make it
 mandatory, then it should be a separate argument (at that point there's no
 reason to include it in the "hook name" argument and then have to split
 apart that string).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/21170#comment:130>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list