[wp-trac] [WordPress Trac] #14179: Theme asking to update (theme with same name on WordPress.org)
WordPress Trac
noreply at wordpress.org
Thu Jul 20 12:57:38 UTC 2017
#14179: Theme asking to update (theme with same name on WordPress.org)
----------------------------+----------------------------
Reporter: design_dolphin | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: WordPress.org
Component: Themes | Version:
Severity: normal | Resolution:
Keywords: | Focuses:
----------------------------+----------------------------
Comment (by dingdang):
While the above idea's top priority is minimal need of new code and looks
a little "hacky" with slug prefixes it has:
PROS:
- partially backward compatible with older versions of WP
- little code to implement
CONS:
- need a whole new functionality to generate UIDs
- doesn't resolve the problem for old existing themes
The second idea below however addresses all the problems but needs more
coding and server resources:
PROS:
- solves ALL problems
- fully backward compatible (old WP versions)
- solves the problem for OLD existing themes as well
- solves the "Active installs" count problem (and so the Popular page list
will be automatically fixed counting only wp.org's theme active installs,
not of the external)
- no need to change/add anything from developer's standpoint
- no need for UUIDs
- no need for changes in the core
CONS:
- a little more complicated to implement
- requires (a little) more system resources
1. For all OLD and NEW themes and all of their versions in the svn an MD5
HASH will be calculated based on the concatenation of
(slug)+(author)+(author uri) (These are reported even by WP 3.0, haven't
checked older versions).
2. A dedicated database with relations **theme slug** - **MD5 HASH** will
be created. So for the theme "ABC" there will be a list of N hashes for
the present N versions of that theme. Adding of new versions and new
themes will expand those lists.
3. API will calculate the MD5 HASH when the data is received from a site
for an active theme report; will check in the above database based on the
theme's slug if the HASH is present; if yes - the theme is native for
wp.org; if not - the theme is an external one; if external - doesn't send
an update info back to the site.
4. Same will done by the Active installs calculator - will count only
those active themes, which HASHes are present in the database for the
specific theme slug. All the themes will get their REAL counts.
@joyously @grapplerulrich @otto42
--
Ticket URL: <https://core.trac.wordpress.org/ticket/14179#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list