[wp-trac] [WordPress Trac] #41345: 'import' group tests fail using git repository
WordPress Trac
noreply at wordpress.org
Tue Jul 18 09:38:18 UTC 2017
#41345: 'import' group tests fail using git repository
-------------------------------------+------------------------------
Reporter: enrico.sorcinelli | Owner: jnylen0
Type: enhancement | Status: assigned
Priority: normal | Milestone: Awaiting Review
Component: Build/Test Tools | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch needs-refresh | Focuses:
-------------------------------------+------------------------------
Changes (by jnylen0):
* keywords: has-patch => has-patch needs-refresh
* owner: => jnylen0
* status: new => assigned
Comment:
I don't think we should skip these tests - the changes in [40531] and
[40532] were intentional. Without those changes, if someone has an
incomplete test environment and they write patches against plugins or
another feature that is left out of their local testing, then they're
increasing the chance of writing a bad patch that fails a build later on.
Quoting from #40533:
> If the test data isn't valid or the environment is not capable of
supporting the test then the test should fail, otherwise the tests are not
reliable.
I added a new section to the handbook page on `git` that explains what is
going on: https://make.wordpress.org/core/handbook/contribute/git/#unit-
tests
Let's leave the test failures in place, but link to this new documentation
from the test failure messages. Something like this:
This test requires the WordPress Importer plugin to be installed. See:
https://make.wordpress.org/core/handbook/contribute/git/#unit-tests
--
Ticket URL: <https://core.trac.wordpress.org/ticket/41345#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list