[wp-trac] [WordPress Trac] #40951: New Text Widget - Switching Between Visual/Text Editor Strips Out Code

[WordPress Trac]

#40951: New Text Widget - Switching Between Visual/Text Editor Strips Out Code
-------------------------------------------------+-------------------------
 Reporter:  dwrippe                              |       Owner:
     Type:  defect (bug)                         |  westonruter
 Priority:  normal                               |      Status:  reopened
Component:  Widgets                              |   Milestone:  4.8.1
 Severity:  major                                |     Version:  4.8
 Keywords:  needs-testing has-unit-tests has-    |  Resolution:
  patch commit fixed-major needs-dev-note        |     Focuses:
-------------------------------------------------+-------------------------

Comment (by Ov3rfly):

 Replying to [comment:145 westonruter]:
 > Replying to [comment:139 Ov3rfly]:
 > > 3. Please notify all plugin/theme authors who add shortcode processing
 for text widgets about this requirement.
 >
 > Good idea. I'll work on that by [https://github.com/markjaquith
 /WordPress-Plugin-Directory-Slurper slurping] down all plugins and ...

 Don't forget all themes, in theme repository, and all commercial sellers,
 and all abandoned plugins, and all abandoned themes, and also all private
 coders... '''well, no. Don't do notify anybody. It is simply not
 possible.''' The initial suggestion was made to hopefully lead you to this
 conclusion.

 The only solution is:

 > > 7. If a shortcode outputs HTML comments, the layout in front end is
 broken with 4.8 due to unwanted added <p> tags, see above.
 >
 > This should not happen because ...

 It is happening now, with a 4.8 updated site and a shortcode which outputs
 a <ul> with a few <li> and one "commented" <li> which is printed as <p>
 now, which is bad, very bad, and required code changes within the
 shortcode PHP-Code. We don't have time to look at any future patches, we
 have to deal with customers who updated to 4.8 and all their broken
 widgets at the moment.

 You can't expect any/all WordPress users to (even be able to) transfer all
 their widgets to other widgets just because somebody had the tiny bad idea
 to change a "since ever existing" core widget to something else instead of
 adding a new widget for a completely new feature. People now are upset
 about WordPress already because their "site looks different" and they "did
 not do anything" and they have to pay hourly rates to get their sites
 fixed. Even if they somehow will manage it alone, to copy that "whatever
 it is" shortcode to a new HTML widget, the shortcode won't even work
 there, just imagine that disappointment.

 Sorry about this rant, nothing personal, a real and clean solution would
 be a complete rollback of "text widget" to pre-4.8 as soon as possible and
 add a new "tinymce widget" for future use.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40951#comment:151>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform