[wp-trac] [WordPress Trac] #40951: New Text Widget - Switching Between Visual/Text Editor Strips Out Code

[WordPress Trac]

#40951: New Text Widget - Switching Between Visual/Text Editor Strips Out Code
-------------------------------------------------+-------------------------
 Reporter:  dwrippe                              |       Owner:
     Type:  defect (bug)                         |  westonruter
 Priority:  normal                               |      Status:  reopened
Component:  Widgets                              |   Milestone:  4.8.1
 Severity:  major                                |     Version:  4.8
 Keywords:  needs-testing has-unit-tests has-    |  Resolution:
  patch commit fixed-major needs-dev-note        |     Focuses:
-------------------------------------------------+-------------------------
Changes (by westonruter):

 * keywords:  needs-testing has-unit-tests has-patch commit fixed-major =>
     needs-testing has-unit-tests has-patch commit fixed-major needs-dev-
     note


Comment:

 Replying to [comment:139 Ov3rfly]:
 > 3. Please notify all plugin/theme authors who add shortcode processing
 for text widgets about this requirement.

 Good idea. I'll work on that by [https://github.com/markjaquith/WordPress-
 Plugin-Directory-Slurper slurping] down all plugins and `ack` for
 instances of shortcode handling being added to widgets. We should also
 publish a new dev-note that introduces the Custom HTML widget and the
 legacy mode for the Text widget.

 > 7. If a shortcode outputs HTML comments, the layout in front end is
 broken with 4.8 due to unwanted added <p> tags, see above.

 This should not happen because [https://github.com/xwp/wordpress-
 develop/pull/235/commits/6e6b53df1f5ccdcc009682dcc9166c88d8c2c56d 6e6b53d]
 moves `do_shortcode` from `widget_text` to `widget_text_content` after
 `wpautop` will have already applied. Please test to confirm.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40951#comment:145>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform