[wp-trac] [WordPress Trac] #40263: REST API: Allow site admins to edit user roles in multisite

[WordPress Trac]

#40263: REST API: Allow site admins to edit user roles in multisite
-------------------------------------------------+-------------------------
 Reporter:  flixos90                             |       Owner:  flixos90
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.8.1
Component:  REST API                             |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests ms-roadmap  |     Focuses:  multisite
  commit                                         |
-------------------------------------------------+-------------------------
Changes (by jnylen0):

 * keywords:  has-patch has-unit-tests ms-roadmap => has-patch has-unit-
     tests ms-roadmap commit
 * milestone:  4.9 => 4.8.1


Comment:

 [attachment:40263.2.diff] adds a couple more tests for the errors and for
 the moderately tricky logic branch that verifies that only the `id` and
 `roles` parameters are set, and also clarifies this logic and adds a
 comment.

 The updated patch runs the new tests in single-site mode as well, which we
 can and should do.  The behavior in single-site mode before and after this
 patch is almost exactly the same (`rest_cannot_edit` changes to
 `rest_cannot_edit_roles` if only a `roles` update is attempted, which is
 fine).

 I think this is fine to ship in 4.8.1.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40263#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform